Phabricator Meetup

Areas to follow up sharing information on

  • From Dropbox:
  • Share what we do on lint ratcheting tactics
  • Compare numbers on review latency
  • CI integration — Wikimedia is interested
  • From Twitter:
  • Diffusion perf (find or file an upstream task)
  • Diffusion search and symbol-linking
  • Land from web design, after it’s implemented
  • Keep in touch on developments in:
  • dependent revisions / stacked diffs
  • comment metadata: “change this” vs “suggestion” vs “question”; done/not-done
  • comment threading

Key interesting things learned we (Dropbox) might want to follow up on

  • Staging area
  • End-to-end Git transport
  • Land from web
  • This exists upstream and seems useful
  • Requires “staging area”, probably also some customization to send to CQ
  • Worth investigating how difficult this will be
  • After the implementation, Twitter will share their design with Dropbox
  • Ask after Jira integration — can we borrow something useful?
  • Look into making arc land faster
  • Look into getting DBAs to manage Phabricator database
  • Consider generating Phabricator jump to definition information in mypy
  • Talk to upstream about adding date queries to search UI
  • Talk to upstream about their plans for Diffusion speed
  • Investigate clustering to see if it would be helpful for our page load speed

Raw notes

  • twitter manages developer laptops directly (vs Dropbox in VMs), so they can basically depend on lint.
  • very similar submit queue sort of thing.
  • there’s pending work to change arc patch to pull from staging area instead of actually patching
  • twitter interested in lint ratcheting tactics
  • wikimedia’s phabricator is fairly fast. how fast?
  • homepage
  • On trying it out later in the meeting: feels reasonably fast, faster than ours, not lightning fast. Maybe 300-1500ms for various pages.
  • wikimedia has a huge number of repos — browsing them is difficult.
  • twitter: any user can create a git repository. have logic to automatically import any repo created on git server into phabricator.
  • wikimedia: main code review interface is not phabricator. project to transition from gerrit(?) issues with phabricator: people not liking arc, CI integration.
  • using Uber plugin for Jenkins integration.
  • twitter also transitioning away from gerrit—near term.
  • wikimedia: think it’s because databases are super optimized, wikimedia uses mysql a lot and have a lot of DBA expertise.
  • gerrit