<feel free to use this spot to add things you’ve noticed that aren’t on the lists bellow>
Next task:
bugs/issues:
(things that can be worked on immediately)
fonts(type, size and color) are a little inconsistent between the search bar and the navbar.
Behavior for Esc with search open / closed
Also, behavior of compose box?(maybe out of scope here)
chrome emoji resize bug
→ This is annoying and hard to fix, the core problem is that chrome calculates the width of emoji differently to say firefox… In addition, some emoji behave differently when they reach the break point where they would be hidden, eg the heart above. When we shifted down the size of the emoji to 15x15 this effect was diminished. It would still be great to find an actual fix for this.
clicking on the non-search icon area of the search bar should open up the stream settings in the subscription modal(if you prefer a smaller click area, maybe just the stream name area on the far left like #feedback)
→ only did the first step, by shrinking the emoji down to 15px by 15px
Clicking outside the search box should either preserve the typed query or close the search box.
→ Would probably be easier to close the search box in this case, but not sure if that’s what we want.
→ deselecting the search box will not close it or reset the filter, but clicking‘X’ will close the filter.
show the whole stream description on hover, if the stream description is cut off
overlap of a long topic name(when opened in search filter) with the"X" looks a little funny
→ overflow: ellipses?
Behavior for‘.search-icon search-open’ after we make“x” close the search.
Type ahead is a bit buggy on fast clicks.
"X” should close the search bar / re-narrow based on some custom mapping
link styling is broken.
gray text in dark mode has poor contrast with the dark background(may want to aim for a more off-white color)
Behavior for“X”. We expect that it should just close the search box.
→ This should be fixed for all narrows but for some reason it doesn’t work on just the home / all narrow.(still investigating that). <finally done>
clicking the × on the search bar should reset the search filter
change the hover text to show the exact number(10,590,11,243, etc) of subscribers
User counts in 1000s range should be rendered with“k”
emoji rendering in stream descriptions
Add more space to the left of the margin here:
image
there is too much space to the right of the #
# should probably be a little bolder
night mode background isn't quite right: has the darker background, that we want only for an active search box, present unconditionally.
right spacing is a little funky on smaller windows.
that light box in the corner is the problem.
Gear and“x” icon overlap in night mode at small view ports and search color bleeds out onto it
A right border appears near the"group" icon when search is closed, and disappears when search is opened.
→previously thought it would be better to: have the right border between the search icon and the gear icon when search is closed, and nothing when it is open.
→ was simpler to just remove it.
Using the“user-list-to-left” setting breaks our spacing on smaller view ports
new bugs/regressions that need triage:
Next task:
bugs/issues:
open/ closed→ Would probably be easier to close the search box in this case, but not sure if that’s what we want.This should be fixed for all narrows but for some reason it doesn’t work on just the home / all narrow.(stillinvestigating that). <finally done>previously thought it would be better to: have the right border between the search icon andthe gear icon when search is closed, and nothing when it is open.was simpler to just remove it.