if needed: we can live with this, if we have to, but really should fix
meh: we can totally ship without this
weak test: this test is outdated and needs to be updated for NLL
💯 : nothing to see here, move along
lang issue: an open question needs to be resolved by the Rust language design team
if no priority seems to fit, we can add one?
Describe problems in NOTES:
in particular, for missing suggestions, copy/paste the text so we can categorize that later
Tag with the right things:
specificity: we used to be more specific
suggestion: we use to make a nice suggestion
span: we’re giving a bad span(highlighting a suboptimal part of the code)
update: test needs to be updated to trigger errors in NLL
How many MY EYES rows?(Note that a single row may have multiple github issues associated with it.)
As of 30 May: 15 rows are marked“MY EYES”.
Below the first table(which just enumerates each test where NLL and AST-borrowck differ in their stderr output), I have a table that tries to summarize the status for each issue associated with the first table.(Info like number of tests tagged with the issue, and a link to any PR’s related to resolving the issue.)
span:“borrow later used here” — we select the entire x += x which spans multiple lines; unclear that the original selection is so great either. Maybe the += would be ideal.(Issue51000)
suggestion:“consider changing this to mut"(#51031)
New Tables circa July/August 2018
Original Tables circa April/May 2018 below
Tables
Instructions for Table 1:
TESTS where NLL and AST-borrowck differ
TEST
OLD ERR
PRIORITY
NOTES
TRACKING ISSUE